software-mansion / react-native-gesture-handler

Declarative API exposing platform native touch and gesture system to React Native.
https://docs.swmansion.com/react-native-gesture-handler/
MIT License
6.13k stars 982 forks source link

[`ReanimatedSwipeable`] Multiple bug fixes and improvements #3149

Closed latekvo closed 1 month ago

latekvo commented 1 month ago

Description

This PR applies multiple bug fixes and improvements to the ReanimatedSwipeable

Changes:

Test plan

Will create an example showcasing outputs of all the affected callbacks, work in progress.

m-bert commented 1 month ago

This PR applies multiple bug fixes and improvements to the ReanimatedSwipeable

Is it necessary to fix all of them in just 1 PR? I'd prefer to split it into smaller ones if possible.

latekvo commented 1 month ago

Is it necessary to fix all of them in just 1 PR? I'd prefer to split it into smaller ones if possible.

Most of them are very minor, most also depend on each other / are fixes to the same part of ReanimatedSwipeable.

I can split them up if you'd prefer that but i think it'd significantly complicate the process, i'll definitely have to deal with conflicts, and PRs blocking eachother.