Closed latekvo closed 1 month ago
This PR applies multiple bug fixes and improvements to the ReanimatedSwipeable
Is it necessary to fix all of them in just 1 PR? I'd prefer to split it into smaller ones if possible.
Is it necessary to fix all of them in just 1 PR? I'd prefer to split it into smaller ones if possible.
Most of them are very minor, most also depend on each other / are fixes to the same part of ReanimatedSwipeable
.
I can split them up if you'd prefer that but i think it'd significantly complicate the process, i'll definitely have to deal with conflicts, and PRs blocking eachother.
Description
This PR applies multiple bug fixes and improvements to the
ReanimatedSwipeable
Changes:
open
andwillOpen
callbacks.startDrag
callbacks receiving invaliddirection
when opening swipeable.close
andwillClose
callbacks.onSwipeableWillClose
andonSwipeableClose
callbacks sometimes being called on open.progress
value skipping last10%
of it's range and having a delay relative to thetranslation
.closes #3147
Test plan
Will create an example showcasing outputs of all the affected callbacks, work in progress.