search

software-mansion / react-native-reanimated

React Native's Animated library reimplemented
https://docs.swmansion.com/react-native-reanimated/
MIT License
8.67k stars 1.27k forks source link

Fix CI issues with yarn #5996

Closed tjzel closed 2 months ago

tjzel commented 2 months ago

Summary

Due to changes to React Native app template, it uses Yarn 3.6.4 out of the box now. This version of Yarn cannot resolve packages from GitHub's pull request refs. Therefore we have to resolve it for it and install via a downloaded package. It's not something crazy - Yarn 1 would do exactly those steps.

Test plan

Should not fail on the dependency installing steps with yarn. Ideally, they shouldn't fail at all.

tjzel commented 2 months ago

I fixed issues with regard to RN template using Yarn 3.6.4 by default.

@tomekzaw @piaskowyk Could you take a look at the failing V8 and monorepo CIs? I have the following questions.

  1. Does V8 CI fail because it doesn't yet support RN 0.74? Maybe you can see it on the spot, I haven't investigated it.

  2. What's exactly the purpose of the monorepo CI? It creates the following file structure:

.
└── monorepo
    ├── RootApp
    └── packages
        └── PackageApp

Which doesn't make a lot of sense - creating the RootApp step. Could you explain a bit your intentions behind this?

EDIT: Thanks for discussing it with me offline.