software-mansion / react-native-reanimated

React Native's Animated library reimplemented
https://docs.swmansion.com/react-native-reanimated/
MIT License
8.88k stars 1.3k forks source link

Remove `getJSValue` in favor of `toJSValue` #6042

Closed tomekzaw closed 3 months ago

tomekzaw commented 4 months ago

Summary

Here's the current implementation of Shareable::getJSValue:

https://github.com/software-mansion/react-native-reanimated/blob/e661676f2dcb8feaf00bf7b9be29ef9d84c673df/Common/cpp/SharedItems/Shareables.h#L91-L93

This PR removes getJSValue in favor of toJSValue as well as updates all usages.

Test plan

Just run the Example app.