software-mansion / react-native-reanimated

React Native's Animated library reimplemented
https://docs.swmansion.com/react-native-reanimated/
MIT License
8.61k stars 1.26k forks source link

[Web LA] Remove `existingTransform` #6060

Closed m-bert closed 1 month ago

m-bert commented 1 month ago

Summary

A while ago I've noticed that layout animations on mobile throw warning if one tries to add animation into View that has transform property. Now, while working on #5277 I've decided to remove code responsible for applying existing transform on web. Here are the reasons why I believe it is good idea:

  1. It unifies behavior with mobile platforms, which are main target of reanimated.
  2. Some of transforms were not applied correctly and required additional calculations to be implemented (like skew).
  3. Removing existing transforms means removing a lot of ifs and unnecessary code.

Test plan

Tested on example app on LA examples.