search

software-mansion / react-native-reanimated

React Native's Animated library reimplemented
https://docs.swmansion.com/react-native-reanimated/
MIT License
8.6k stars 1.26k forks source link

3.13.0-rc.0 crash on iOS (animated flatlist) in Release build only #6092

Closed karimb11 closed 2 weeks ago

karimb11 commented 3 weeks ago

Description

If you scroll through a flat list that has animated items (Just a boilerplate shared value scale animation per item using Animated.View), you get this exception:

image

This happens in release build only, I also tested multiple previous versions, so it's not exclusive to the latest release of react-native-reanimated.

Steps to reproduce

I'm just looking for some pointers, it's hard to reproduce as the app is rather complex (react-navigation)

Snack or a link to a repository

don't have any

Reanimated version

3.13.0-rc.0

React Native version

0.74.2

Platforms

iOS

JavaScript runtime

Hermes

Workflow

React Native

Architecture

Fabric (New Architecture)

Build type

Release app & production bundle

Device

Real device

Device model

iPhone SE 2

Acknowledgements

Yes

github-actions[bot] commented 3 weeks ago

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

szydlovsky commented 3 weeks ago

Hey @karimb11 it might be due to a recent issue with Shareables, can you please try 3.13.0-rc.1 version? It contains a fix for it

karimb11 commented 3 weeks ago

Hello @szydlovsky , thank you, I tried it but still getting a crash

image

Though the exception seems different now.

bartlomiejbloniarz commented 2 weeks ago

This was caused by an issue in jsi. I explain it more in depth here.

Antisane76 commented 1 day ago

Hi @bartlomiejbloniarz - I'm still seeing this kind of crash error on Android Release builds using the new architecture and hermes. I originally had the same issue on iOS that was occurring here but after patching RN with your PR to RN the iOS issue was resolved.

I've seen a few functions that appear to be causing this on android in the crash logs - setNativeState, setPropertyValue, call

I have a somewhat reliable way of recreating the crash on my app so I'm happy to test any patches or ideas. I've tried 3.12.1 and 3.13.0-rc.2 of reanimated on RN 0.74.2 (with above patch) with no luck.

bartlomiejbloniarz commented 21 hours ago

Hi @Antisane76 👋 How did you apply the patch on Android? I'm asking this question because on Android you have to configure gradle to build RN from source. Otherwise it will use precompiled artifacts.

Antisane76 commented 21 hours ago

Ah good to know. I was just using 'patch-package'. I'll give it a crack and let you know but I bet that will resolve it. Thanks for your time!