Open kirillzyusko opened 2 weeks ago
Do not overwrite propKeysManagedByAnimated with nil
propKeysManagedByAnimated
nil
When you copy propKeysManagedByAnimated - you are copying nil. Later on in
[_mountingManager synchronouslyUpdateViewOnUIThread:tag changedProps:props componentDescriptor:*componentDescriptor];
props gets set to nil and then NSSet with transform key, but in
NSSet
transform
[componentView setPropKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN:propKeysManagedByAnimated];
you set it back to nil.
As a result if re-render during animation happens, it may lead to unexpected jumps during the animation.
Summary
Do not overwrite
propKeysManagedByAnimated
withnil
Explanation
When you copy
propKeysManagedByAnimated
- you are copyingnil
. Later on inprops gets set to
nil
and thenNSSet
withtransform
key, but inyou set it back to
nil
.As a result if re-render during animation happens, it may lead to unexpected jumps during the animation.
Test plan