software-mansion / react-native-reanimated

React Native's Animated library reimplemented
https://docs.swmansion.com/react-native-reanimated/
MIT License
9.12k stars 1.32k forks source link

⭐ [Android] Support 16kb page size for Android 15+ devices #6368

Open k-saparia opened 4 months ago

k-saparia commented 4 months ago

Description

Description

I am encountering issues when running my app on Android 15 devices with a 16 KB page size, particularly with some native components. Are there any plans to recompile the library to address these issues and ensure compatibility with phones that have a 16 KB page size?

As stated on Android doc,

Beginning with Android 15, Android supports devices that are configured to use a page size of 16 KB (16 KB devices). If your app uses any NDK libraries, either directly or indirectly through an SDK, then you will need to rebuild your app for it to work on these 16 KB devices.

An analysis of my app using the APK Analyzer as described by Android shows that it does use libreanimated.so as native code.

image

This is the native binary reported by the APK analysis:

libcrashlytics-common.so

Describe the solution you'd like

I would like for libreanimated.so to support 16kb page size phones so that apps supporting sdk 35 do not crash

Additional context

Android doc: https://developer.android.com/guide/practices/page-sizes#compile-16-kb-alignment react-native thread: https://github.com/facebook/react-native/issues/45054

What Platforms whould this feature/enhancement affect?

Android

Alternatives/Workarounds

No workaround I have investigated so far.

Steps to reproduce

As stated in doc, create emulator with 16kb page size support SDK https://developer.android.com/guide/practices/page-sizes#compile-16-kb-alignment

Snack or a link to a repository

Global issue

Screens version

3.30.1

React Native version

0.72.1 and latest 0.74.2

Platforms

Android

JavaScript runtime

JSC

Workflow

React Native (without Expo)

Architecture

None

Build type

Release mode

Device

Android emulator

Device model

VanillaIceCream Google APIs Page Size 16 KB

Acknowledgements

Yes

github-actions[bot] commented 4 months ago

Hey! πŸ‘‹

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

github-actions[bot] commented 4 months ago

Hey! πŸ‘‹

It looks like you've omitted a few important sections from the issue template.

Please complete Reanimated version and Description sections.

kkafar commented 4 months ago

Hey @k-saparia, is this issue related to react-native-screens, or does it affect this library? From your description I conclude that it is react-native-reanimated who is affected rather than react-native-screens and you should consider opening the issue on it's repo (or let me know, I might be able to transfer the issue there)