software-mansion / react-native-reanimated

React Native's Animated library reimplemented
https://docs.swmansion.com/react-native-reanimated/
MIT License
8.94k stars 1.3k forks source link

The circular reference exists between REASharedTransitionManager and REAAnimationsManager #6604

Open hwris opened 5 days ago

hwris commented 5 days ago

Description

Why does a circular reference exist between REASharedTransitionManager and REAAnimationsManager?

Steps to reproduce

https://github.com/software-mansion/react-native-reanimated/blob/67a9f2d24f3c9f5c3ba7dc7572314b1ab30c9593/packages/react-native-reanimated/apple/reanimated/LayoutReanimation/REAAnimationsManager.m#L47

https://github.com/software-mansion/react-native-reanimated/blob/67a9f2d24f3c9f5c3ba7dc7572314b1ab30c9593/packages/react-native-reanimated/apple/reanimated/LayoutReanimation/REASharedTransitionManager.m#L20

Snack or a link to a repository

none

Reanimated version

3.6.1

React Native version

0.73.1

Platforms

iOS

JavaScript runtime

None

Workflow

None

Architecture

None

Build type

None

Device

None

Device model

No response

Acknowledgements

Yes

github-actions[bot] commented 5 days ago

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

hwris commented 5 days ago

There are also the following two places:

https://github.com/software-mansion/react-native-reanimated/blob/67a9f2d24f3c9f5c3ba7dc7572314b1ab30c9593/packages/react-native-reanimated/apple/reanimated/LayoutReanimation/REAAnimationsManager.m#L81

https://github.com/software-mansion/react-native-reanimated/blob/67a9f2d24f3c9f5c3ba7dc7572314b1ab30c9593/packages/react-native-reanimated/apple/reanimated/LayoutReanimation/REASwizzledUIManager.mm#L23