Closed jankosecki closed 2 weeks ago
same issue
same issue
same issue
Hey, thanks for posting this issue!
Unfortunately, I can't reproduce this bug with the reproducer you provided. After removing patch I'm not receiving any error during the pod install
phase, nor the compile phase.
Is this reproducer correct? I can't find any line for enabling new architecture in this repro 🤔
same issue +1
@necmettindev @nthtrung09it @rayson-intrack @0xDing could you provide a reproducer that reproduces this issue? As I said above, I didn't manage to deduce any bug from provided RN project (even after removing the patch).
@tboba I can reproduce the issues using provided repo. I did the following steps:
patches/react-native-screens+3.34.0.patch
yarn setup
(it invokes "pod-install": "(cd ./ios ; RCT_NEW_ARCH_ENABLED=1 USE_FRAMEWORKS=static bundle exec pod install --repo-update)"
which enables new architecture)None
team in Signing & Capabilities)yarn start
yarn ios
or trigger build from XCode (yarn ios
causes a massive error output with different "error" lines but XCode offers a clear reason:
This is also happening in 0.75.2. Seems like there is something wrong with the pod installation in 75.
I tried this patch but it didn't work. (Fixed the issue but other errors started to come up)
diff --git a/node_modules/react-native-screens/common/cpp/react/renderer/components/rnscreens/RNSScreenComponentDescriptor.h b/node_modules/react-native-screens/common/cpp/react/renderer/components/rnscreens/RNSScreenComponentDescriptor.h
index 37aac4e..5fb5505 100644
--- a/node_modules/react-native-screens/common/cpp/react/renderer/components/rnscreens/RNSScreenComponentDescriptor.h
+++ b/node_modules/react-native-screens/common/cpp/react/renderer/components/rnscreens/RNSScreenComponentDescriptor.h
@@ -6,8 +6,8 @@
#include <react/debug/react_native_assert.h>
#include <react/renderer/components/rnscreens/Props.h>
#include <react/renderer/core/ConcreteComponentDescriptor.h>
+#include <react/renderer/components/rnscreens/utils/RectUtil.h>
#include "RNSScreenShadowNode.h"
-#include "utils/RectUtil.h"
namespace facebook {
namespace react {
With that being said, there is something wrong with the headers linking.
New arch is turned on.
Can reproduce on RN 0.75.2. Using this patch seems to fix it.
This is also happening in 0.75.2. Seems like there is something wrong with the pod installation in 75.
I tried this patch but it didn't work. (Fixed the issue but other errors started to come up)
diff --git a/node_modules/react-native-screens/common/cpp/react/renderer/components/rnscreens/RNSScreenComponentDescriptor.h b/node_modules/react-native-screens/common/cpp/react/renderer/components/rnscreens/RNSScreenComponentDescriptor.h index 37aac4e..5fb5505 100644 --- a/node_modules/react-native-screens/common/cpp/react/renderer/components/rnscreens/RNSScreenComponentDescriptor.h +++ b/node_modules/react-native-screens/common/cpp/react/renderer/components/rnscreens/RNSScreenComponentDescriptor.h @@ -6,8 +6,8 @@ #include <react/debug/react_native_assert.h> #include <react/renderer/components/rnscreens/Props.h> #include <react/renderer/core/ConcreteComponentDescriptor.h> +#include <react/renderer/components/rnscreens/utils/RectUtil.h> #include "RNSScreenShadowNode.h" -#include "utils/RectUtil.h" namespace facebook { namespace react {
With that being said, there is something wrong with the headers linking.
New arch is turned on.
@matinzd Could you highlight what are the other errors that were introduced, I don't use this library directly but through "react-navigation" and I don't face any other issues/errors.
#include <react/renderer/components/rnscreens/utils/RectUtil.h>
instead of #include "utils/RectUtil.h"
seems to work in my setups.
Same issue +1
same issue +1
@matinzd this patch sounds better. Thanks!
Should I open a PR for that? Is that gonna break paper builds?
@matinzd Nope, it shouldn't. C++ layer is being built only on new architecture, so the old arch should work well 👍
Description
Hi team,
I've been testing upgrading RN 0.74 to 0.75-RC7 with basic stack including
react-navigation
andreact-native-screens
. The iOS build fails for me with the following error:I have applied the following patch locally (included in the reproduction repo):
but I'm not sure if that's correct way to fix this issue.
Steps to reproduce
patches/react-native-screens+3.34.0.patch
yarn setup && yarn ios
Snack or a link to a repository
https://github.com/jankosecki/react-native-upgrade-tester/tree/rn-0.75
Screens version
3.34.0
React Native version
0.75-RC7
Platforms
iOS
JavaScript runtime
Hermes
Workflow
React Native (without Expo)
Architecture
Fabric (New Architecture)
Build type
Debug mode
Device
None
Device model
No response
Acknowledgements
Yes