fix: remove unnecessary checks for creating snapshot - Githubissues

software-mansion / react-native-screens

Native navigation primitives for your React Native app.

https://docs.swmansion.com/react-native-screens/

MIT License

3.11k stars 521 forks source link

fix: remove unnecessary checks for creating snapshot #2485

Closed WoLewicki closed 1 week ago

WoLewicki commented 2 weeks ago

Description

Based on https://github.com/Expensify/App/pull/49937#issuecomment-2451993625 and the comments above, PR fixes the unnecessary checks for creating snapshot on the view on dismiss. It was refactored already in https://github.com/software-mansion/react-native-screens/pull/2134 and https://github.com/software-mansion/react-native-screens/pull/2261 (👏 to @kkafar). Those checks do nothing now since each screen is responsible for making its own snapshot. Having those checks can only lead to problems.

kkafar commented 1 week ago

I've restarted the CI & we need to update the podfile lock.