support macos & windows

software-mansion / react-native-svg

SVG library for React Native, React Native Web, and plain React web projects.

MIT License

7.43k stars 1.12k forks source link

support macos & windows #297

Closed liuhong1happy closed 2 years ago

liuhong1happy commented 7 years ago

Links

x-ji commented 2 years ago

Just curious: while Googling around I saw that MS announced that they started to support SVG natively with React Native for Windows in this post from Feb 2020. https://microsoft.github.io/react-native-windows/blog/2020/02/010/m4updates#svg-image-support I guess this library probably provides more flexibility and configuration options? Or I guess maybe a number of existing libraries already depend on this library for them to work.

x-ji commented 2 years ago

FYI I think this library already works on MacOS as long as the build target is > MacOS 10.14. See this question: https://stackoverflow.com/questions/68510491/react-native-macos-component-exception I also tried it myself and it worked out of the box :) pod install was able to install RNSVG directly and the SVGs are displayed as expected.

WoLewicki commented 2 years ago

I'm closing this since https://github.com/react-native-svg/react-native-svg/pull/1632 was merged. Feel free to comment here if something is wrong and we can always reopen it then.