search

software-mansion / starknet.py

✨ 🐍 Python SDK for Starknet.
https://starknetpy.rtfd.io/
MIT License
258 stars 80 forks source link

Use previous Ledger app version and re-enable Ledger signer tests #1487

Closed franciszekjob closed 3 weeks ago

franciszekjob commented 3 weeks ago

Closes #

Introduced changes

Ledger Starknet app latest version has changed APDU command. It doesn't support e.g. signing deploy account transaction) which is used in our tests. Due to it, we use previous version. Once future release of Starknet app will support features used in out tests, updating versions and tests should be addressed in https://github.com/software-mansion/starknet.py/issues/1473.

franciszekjob commented 3 weeks ago

I think it's better if we include information that our interface doesn't allow clear-signing transactions yet, instead it allows to blind-sign. This is more better information for an end-user imo. Wdyt @ddoktorski ?

franciszekjob commented 3 weeks ago

offline discussion: We will add info about the app's version, as it's visible when installing on Ledger device so it's worth to include it.