software-mansion / starknet.py

✨ 🐍 Python SDK for Starknet.
https://starknetpy.rtfd.io/
MIT License
260 stars 82 forks source link

Missing RC_96, add_mod, mul_mod builtins in ComputationResources #1513

Open feltroidprime opened 1 day ago

feltroidprime commented 1 day ago

Feature Request

https://github.com/software-mansion/starknet.py/blob/2a8419009c21628c4514f3c3611f3652f5eba124/starknet_py/net/client_models.py#L394-L410

image

it's been around 2 months those 3 builtins were added to the VM

franciszekjob commented 17 hours ago

Hi @feltroidprime , could you please link the reference in cairoVM? These changes aren't reflected in https://github.com/starkware-libs/starknet-specs/blob/6d88b7399f56260ece3821c71f9ce53ec55f830b/api/starknet_api_openrpc.json#L3454 🤔 .

Btw, ComputationalResources will be entirely removed in the new RPC 0.8.0 and we will use updated ExecutionResources.