Consider removing optional params in favor of overloaded functions

software-mansion / starknet.swift

Starknet SDK for Swift language

MIT License

24 stars 15 forks source link

Consider removing optional params in favor of overloaded functions #136

Closed DelevoXDG closed 9 months ago

DelevoXDG commented 9 months ago

Feature Request

From https://github.com/software-mansion/starknet.swift/pull/129/files#r1455383229

I think the logic with StarknetOptionalExecutionParamsV3 is not ideal, and overloaded functions like in jvm would be better. But to not further complicate this PR, I decided to follow the approach already used for v1 txs.

DelevoXDG commented 9 months ago

Duplicate of #135