Verify types in `StarknetTypedData` in line with SNIP-12 - Githubissues

software-mansion / starknet.swift

Starknet SDK for Swift language

MIT License

24 stars 15 forks source link

Verify types in `StarknetTypedData` in line with SNIP-12 #170

Closed DelevoXDG closed 6 months ago

DelevoXDG commented 7 months ago

Stack

172
166
167
170
173
174
175
178
182
180
181

Describe your changes

Ensure type verification logic in line with these guidelines. Restrictions related to enum basic type will be added separately.

Verification

Disallow empty names, names with *, dangling types
Require domain type to be present in types

Initializers

Make initializers throwing instead of failable
Override decoding initializer to ensure type verification

Linked issues

Closes

Breaking changes

[x] This issue contains breaking changes

StarknetTypedData initializers are now throwing, not failable
Type verification is now enforced when instantiating StarknetTypedData