Refactor `StarknetProvider` and `StarknetRequest` - Githubissues

software-mansion / starknet.swift

Starknet SDK for Swift language

MIT License

24 stars 15 forks source link

Refactor `StarknetProvider` and `StarknetRequest` #217

Closed franciszekjob closed 1 month ago

franciszekjob commented 2 months ago

Describe your changes

This PR focuses on refactoring StarknetProvider, StarknetRequest and related structs/protocols for sending RPC calls.

Introduced changes:

Move logic responsible for building requests form StarknetProvider to StarknetRequest which is now just a container for a RPC call.
Remove send method from StarknetRequest.
Add send method to StarknetProvider responsible for sending single/multiple RPC calls.

Linked issues

Closes #215

Breaking changes

[x] This issue contains breaking changes
Move methods responsible for building RPC calls from StarknetProvider to StarknetRequest.
Remove send method from StarknetRequest - use added send in StarknetProvider to send RPC calls
Add provider param in estimateFeeV1 and estimateFeeV3 in StarknetAccountProtocol; Update following methods in StarknetAccount

THenry14 commented 2 months ago

@DelevoXDG please also take a look