GHA add npm build step - Githubissues

softwareCobbler / luceedebug

line debugger for lucee

GNU Lesser General Public License v2.1

44 stars 15 forks source link

GHA add npm build step #25

Closed zspitzer closed 1 year ago

softwareCobbler commented 1 year ago

Thanks for the contrib. I think for this to generate a useful artifact, it would have to npm install vsce and run vsce package. This would produce a VSIX file that is basically "the plugin zipped up and installable from vscode".

What would it take to:

only trigger on push to master
cache java and npm deps (i'd wager we could beat the current ~1m35s build time) ?

zspitzer commented 1 year ago

Running CI on pull requests is pretty normal, if you disable that, then you won't see if a PR is valid until you merge it and the same goes for forks?

I've added caching and a vsce package step plus caching (gradle caching only saves with runs on master by default, so it should be faster once merged)

softwareCobbler commented 1 year ago

Ah, yes, now I see the light. "Does it at least compile?" is a nice question to ask against pull requests.