search

softwareCobbler / luceedebug

line debugger for lucee
GNU Lesser General Public License v2.1
44 stars 15 forks source link

Version/Tag the Agent #42

Open jamiejackson opened 1 year ago

jamiejackson commented 1 year ago

I tend to pin versions of dependencies to prevent surprises; however, the agent, itself doesn't have version tags.

I do this in my Dockerfile, but tags would be cleaner:

RUN git clone https://github.com/softwareCobbler/luceedebug.git /tmp/luceedebug \
  && cd /tmp/luceedebug \
  && git checkout 6c5e3ff3641773ba57ff0f5ff36346e2acdac495 # 5/17/23

Upgrade:

RUN git clone https://github.com/softwareCobbler/luceedebug.git /tmp/luceedebug \
  && cd /tmp/luceedebug \
  && git checkout 91d662287f2a69271a476d949c034b2cb4e3cf19 # 6/2/23

That's workable but it would be more standard to use tags.

I realize that we kinda have two projects in one here, the VS Code Extension and the Agent, which complicates things a little.

However, I don't see why we couldn't have two different tagging schemes going on and it looks like you foresaw it because you're namespacing the VS Code Extension tags like vsclient/2.0.5. Maybe something like serveragent/x.x.x would work?

softwareCobbler commented 1 year ago

Tags for the client represent definitive vscode marketplace submission events, whereas the agent doesn't have a strongly guiding tagging principle; it's primarily a "we know it when we see it" type situation. That said, HEAD is now tagged as agent/2.0.6, which is mostly an arbitrary number, but with some consideration for the agent/client sharing a major version.