search

softwareCobbler / luceedebug

line debugger for lucee
GNU Lesser General Public License v2.1
44 stars 15 forks source link

Enhancement: Rename cfHost & cfPort to debugHost & debugPort #6

Closed jamiejackson closed 1 year ago

jamiejackson commented 1 year ago

I'm in the ephemeral position where I'm new enough to the project that I'm not used to any counterintuitive quirks, so I'm trying to document or fix them as I go along, before I no longer notice them.

I think the cfHost and cfPort variables are confusingly named and I kept having to refer to the readme because of the cognitive dissonance. As far as I know, these are not really the Lucee/ColdFusion host and port but the debugger connection information. (The Lucee host, and especially the port, are something completely different than the debugger attachment host/port.) I think something like debugHost and debugPort wouldn't have made me go back and forth to the documentation as much as I did.

Maybe since the project is still new, it might not be too painful to make a change like that (and maybe there could be an adaptor to set the legacy variable names to the new variables, for backward compatibility).

Just a thought.

jamiejackson commented 1 year ago

Same with the pathTransforms.cfPrefix. I'd suggest something like pathTransforms.serverPrefix.

jamiejackson commented 1 year ago

Please consider #22. In my testing, both the old and the new names worked.