softwareconstruction240 / autograder

Autograder for BYU's CS 240 Chess project
https://cs240.click
2 stars 2 forks source link

backend: Scorer#getScore only considers some of the important portions of the score #353

Closed frozenfrank closed 1 week ago

frozenfrank commented 2 months ago

The method currently looks at the passoffTests, regular tests, and quality score, but it ignores any scoring from the git commits.

Adding GitCommits to the Rubric Item may address this issue, but are there any other places that also need adjustments with new rubric items?

Currently, in all the contexts this method is used, it doesn't matter. However, this is the kind of issue that would cause logical issues in the future if it isn't identified. See this line for the currently identified issue.

This relates to, and would likely be solved by, whatever solves #300.