search

softwareconstruction240 / autograder

Autograder for BYU's CS 240 Chess project
https://cs240.click
2 stars 2 forks source link

check for common issues and provide helpful error messages - package structure and module interdependence #360

Closed 19mdavenport closed 4 months ago

19mdavenport commented 4 months ago

Draft PR so people know what I'm working on and collaborate if needed

resolves #365 resolves #366

frozenfrank commented 4 months ago

@19mdavenport Can I help carry this PR across the finish line now that we've made it this far? At this point, I feel like the main points have been discussed— or at least raised.

Fiwafoofa commented 4 months ago

When I ran this against my code, I get a index error within my SqlDAO.java file here on (I think) line 18 with the curly brace when executing the ModuleIndependenceVerifier with a phase 3 submission. Line 58 String packageImport = line.substring(line.indexOf(' ')).trim(); caused the error with line being equal to "}". My guess is something was off with the Regex. I have to go to class, but when I get back I'll do more debugging.

Screenshot 2024-05-17 095854

Though I may be misunderstanding how this verifier works or missing something obvious.

19mdavenport commented 4 months ago

@Fiwafoofa thank you for looking into that. I think it might just be the beginning string marker (^) at the beginning. I'll try removing that and seeing if that helps

EDIT: It didn't

EDIT 2: How about that?