search

softwareconstruction240 / autograder

Autograder for BYU's CS 240 Chess project
https://cs240.click
2 stars 2 forks source link

Disable canvas and compilation #369

Closed frozenfrank closed 1 month ago

frozenfrank commented 1 month ago

This PR continues efforts begun in #328 by adding guards to newly added method calls. It also leverages the newly added ApplicationProperties system to read in the values from a properties file.

frozenfrank commented 1 month ago

Note that the commit message "RUN_COMPILATION can be controlled via ApplicationProperties" in commit 50cb2c6 is mostly a theoretical question. Nobody has shown me nor demonstrated where the .properties file exists so I'm not sure how to actually use it.

19mdavenport commented 1 month ago

There is no .properties file associated with ApplicationProperties. It's tied to command line arguments

frozenfrank commented 1 month ago

There is no .properties file associated with ApplicationProperties. It's tied to command line arguments

That explains it. I guess I just need some training on how to use the commandline arguments to adjust the values.

Is there something more you're looking for from this PR, or how can I help this one become approved as well?

frozenfrank commented 1 month ago

Could you add support for your new property to where it exists in main Server class, as well as providing it as an option in the docker compose file?

@19mdavenport I can look into the main Server class, but I have now idea how Docker works or while file I would be manipulating. I'll do my best.

19mdavenport commented 1 month ago

https://github.com/softwareconstruction240/autograder/blob/main/compose.yml you'd just need to add it with the rest of the command line arguments (lines 23-32)