softwareconstruction240 / autograder

Autograder for BYU's CS 240 Chess project
https://cs240.click
2 stars 2 forks source link

Only count completed extra credit in notes #371

Closed 19mdavenport closed 4 months ago

19mdavenport commented 4 months ago

This fixes a calculation where students are receiving notes like "Extra credit tests: +5.6%" (had done 1/2 extra credit) and "Extra credit tests: +2.4%" (had done no extra credit). This will be replaced with the correct number (no extra credit display/4%/8%)

19mdavenport commented 4 months ago

The value was the percentage of passed extra credit tests. Some extra credit tests are passed by all students who don't attempt the extra credit as they check that valid moves don't contain what would be valid extra credit moves under different circumstances. It was displaying to students that they had gotten +2.4% or +5.6% extra credit, when the correct values are discreet: 0%, 4%, 8%. To accomplish this, we make sure the value is only added if it is 1 for each category