search

softwareconstruction240 / autograder

Autograder for BYU's CS 240 Chess project
https://cs240.click
2 stars 2 forks source link

Extend the grading window by a configurable amount of minutes for grace #385

Closed frozenfrank closed 1 month ago

frozenfrank commented 1 month ago

Motivation

This implements the request made by @19mdavenport regarding a grace period:

Currently the commit verification is finding the bounds on time between the last submission and when the current submission was made. Do you see any potential problems if we gave them an extra five minutes on either side to account for differences in computer times?

A student got flagged for submitting 21 seconds earlier than the latest commit time

Resolution

The fix is pretty straightforward: push forward the limit window by a small amount to allow for local/server clock inconsistencies. This introduces a configurable value to represent the exact amount, and then adjusts the limit. Thankfully, the change only needs to be made in a single place because the code is well organized.

frozenfrank commented 1 month ago

Thanks for reviewing it so quickly! I have another PR coming soon that addresses #376.

19mdavenport commented 1 month ago

Thanks for reviewing it so quickly!

Sure, honestly I didn't know how much you would be doing in the near future and thought I would have to make this change myself. This is very similar to what I was already thinking of doing.