search

softwareconstruction240 / chess

Chess project for BYU CS 240
2 stars 4 forks source link

Ensure All Test Boards have a White King and Black King for Phase 1 #29

Closed frozenfrank closed 1 month ago

frozenfrank commented 1 month ago

Overview

Currently, most but not all of the Phase 1 tests have kings on the board. Some students assume that all boards have two kings (white and black) and rely on that assumption while performing isInCheck() operations. It has been decided not to test students on their handling of incorrect boards, and to simply provide kings on all Phase 1 test boards.

Phase 0 boards will remain unaffected. They do not need to have kings on them.

TA Meeting Discussion Notes

From the notes taken by @DallinFromEarth (thanks!):

  • Some students write phase 1 check checking code assuming there are kings on the board
  • “I don’t call it hard coding, I call it saving” -Makenna
  • Go add 2 kings to all the test boards in GameTests phase 1. Its ok as is on phase 0
  • We won’t check what happens when they’re given an invalid board
19mdavenport commented 1 month ago

I was already planning on working on some other improvements to the test cases, so I can do this as part of that.