delorean can exit without building anything and without feedback

softwarefactory-project / DLRN

DO NOT send Pull Requests here, send reviews to

https://softwarefactory-project.io/r/#/q/project:DLRN

Apache License 2.0

28 stars 24 forks source link

delorean can exit without building anything and without feedback #11

Closed dmsimard closed 5 years ago

dmsimard commented 9 years ago

See:

$ delorean --config-file projects.ini --local --package-name python-openstackclient; echo $?
INFO:delorean:Getting git://github.com/openstack-packages/python-openstackclient to ./data/python-openstackclient_distro
INFO:delorean:Getting git://git.openstack.org/openstack/python-openstackclient to ./data/python-openstackclient
0

(that's it)

There are no rpmbuild.log files generated.
Nothing in audit.log

Need to find some time to troubleshoot further.

dtantsur commented 9 years ago

This, for example, happened to me when I provided wrong command line flags

dmsimard commented 8 years ago

So @trown let me know this is related to the commits.sqlite file.

It goes like this:

Run delorean once on a package (data is generated in delorean/data and commits.sqlite file is updated in delorean/commits.sqlite)
Delete delorean/data
Run delorean again on the same package
Returns without nothing as described in OP

Moving or deleting the commits.sqlite resolves this issue so it looks like we could handle that better.

javierpena commented 8 years ago

@dmsimard in the example you provided, Delorean is working as designed. It stored the latest commit number for the uptream and dist-git repos in the database, and it did not re-create the package because there was no change in any of them.

It you need to run delorean on the same data more than one, use the --dev flag.

dmsimard commented 8 years ago

@javierpena it's okay if it's meant to be like that but it should at least tell you something and not just exit without telling you anything. It's not very user friendly :)

snecklifter commented 7 years ago

Yeah, I agree with @dmsimard it would be nice to output something, I am just onboarding and this was confusing, I didn't know what had actually happened.

javierpena commented 7 years ago

Ok, it would make sense to make DLRN report that no commits can be built for the common reasons (no new commit or non-existing package). I've added it to https://softwarefactory-project.io/storyboard/#!/story/206

javierpena commented 5 years ago

This was fixed in https://softwarefactory-project.io/r/9277