search

softwarefactory-project / rdopkg

power to the packagers
Apache License 2.0
28 stars 21 forks source link

rdopkg >= 0.43 appends # patches_base even when not needed #122

Closed yac closed 7 years ago

yac commented 7 years ago

This can be seen for example by running rdopkg new-verision 0.44 in it's own master:

 Source0:          https://pypi.python.org/packages/source/r/%{name}/%{name}-%{version}.tar.gz

+#
+# patches_base=0.44
+#
+
 BuildArch:        noarch

patches_base is uneeded.

yac commented 7 years ago

This was introduced by b328265749f5629fd41679e153acd6de6d95e07d pre 0.43.

yac commented 7 years ago

No more hax. Correct solution to this is a maintainable unit tested magic comments parser.

yac commented 7 years ago

As a first step, unit tests are needed to cover wanted behavior, but that is very hard with current unit tests and thus first #123 must be solved.

yac commented 7 years ago

This actually happens only when I test on rdopkg distgit but not on the testing one in https://softwarefactory-project.io/r/#/c/8679/ so it must be a special case. Need to find out what triggers this.

yac commented 7 years ago

Hahaha, rdopkg distgit was probably the only one to ever get hit by this bug because it has filter_patches string in the changelog :D Here is a fix of a hack before we get proper fix for this whole patches_* comments mess: https://softwarefactory-project.io/r/#/c/8930/