search

softwarefactory-project / rdopkg

power to the packagers
Apache License 2.0
28 stars 21 forks source link

avoid macros in changelogs #142

Closed ktdreyer closed 5 years ago

ktdreyer commented 6 years ago

If a git commit title has a percent "%" character, rdopkg patch will write that character directly into the %changelog. RPM interprets this as a macro, and I suspect it causes other tools to choke as well (currently chasing a bug in compose-utils / kobo that may be related).

A simple solution would be to just unilaterally escape all % signs before writing the changelog.

ktdreyer commented 6 years ago

(the compose-utils bug proved to be completely unrelated, but we should still avoid writing a single percent sign in the %changelog)

yac commented 6 years ago

That's correct, changelog entries sould have % escaped.

yac commented 5 years ago

Fixed in master.