softwarefactory-project / rdopkg

power to the packagers
Apache License 2.0
28 stars 21 forks source link

Normalize commit messages #143

Closed yac closed 6 years ago

yac commented 6 years ago

Let's define the best format for commit messages generated by rdopkg using feature tests and then make all rdopkg actions use it consistently.

I suggest NVR as commit title with changelog list as commit body for all actions that modify Release regardless of # of changelog lines:

package-name-1.2.3-4

Changelog:
- This
- That
- What Not

Resolves: ...
Change-Id: ...

Don't forget to also test rdopkg patch -H <file>.

rdopkg update-patches is special as it doesn't bump NVR.

140 is related and might be solved as part of this effort.

fuzzball81 commented 6 years ago

Where would the text be inserted when using the -H option?

yac commented 6 years ago

We discussed the best way to handle -H is probably to replace NVR with -H content and append the usual changelog and stuff.

yac commented 6 years ago

121 is also related, make sure -H and --bug interact nicely.

yac commented 6 years ago

Work in Progress: https://softwarefactory-project.io/r/#/c/9781/