search

softwarefactory-project / rdopkg

power to the packagers
Apache License 2.0
28 stars 21 forks source link

rdopkg new-version do not entertain short %macros in Name: #161

Closed karelyatin closed 5 years ago

karelyatin commented 5 years ago

Detected in:- https://review.rdoproject.org/r/#/c/15777/1 and https://review.rdoproject.org/r/#/c/15772/1

If spec contains macro in Name:,

rdopkg new-version -U -b will add the macro(without expansion) in the commit message.

For example:- %global library kuryr-lib Name: python-%library

rdopkg new-version -U -b 0.8.0 will add following commit message:-

python-%library-0.8.0-1

Changelog: - Update to 0.8.0

yac commented 5 years ago

So this was just a bad detection of short macros fixed by https://softwarefactory-project.io/r/#/c/14252/ .