search

softwarefactory-project / rdopkg

power to the packagers
Apache License 2.0
28 stars 21 forks source link

Pkgenv fails with TypeError #180

Closed Akrog closed 4 years ago

Akrog commented 4 years ago

When we run rdopkg pkgenv we get:

Traceback (most recent call last):                                                                                                                                                                                                                                                                    
  File "/usr/bin/rdopkg", line 10, in <module>                                                                                                                                                                                                                                                        
    sys.exit(main())                                                                                                                                                                                                                                                                                  
  File "/usr/lib/python2.7/site-packages/rdopkg/cli.py", line 49, in main                                                                                                                                                                                                                             
    sys.exit(rdopkg(*cargs))                                                                                                                                                                                                                                                                          
  File "/usr/lib/python2.7/site-packages/rdopkg/cli.py", line 41, in rdopkg                                                                                                                                                                                                                           
    version=__version__)                                                                                                                                                                                                                                                                              
  File "/usr/lib/python2.7/site-packages/rdopkg/shell.py", line 87, in run                                                                                                                                                                                                                            
    action_runner.engage()                                                                                                                                                                                                                                                                            
  File "/usr/lib/python2.7/site-packages/rdopkg/core.py", line 212, in engage                                                                                                                                                                                                                         
    new_args = self.action_manager.run_action(step, self.args)                                                                                                                                                                                                                                        
  File "/usr/lib/python2.7/site-packages/rdopkg/action.py", line 252, in run_action
    return action_fun(*fun_args)
  File "/usr/lib/python2.7/site-packages/rdopkg/actions/distgit/actions.py", line 118, in show_package_env
    gerrit_review_url = rpmfactory.review_url(gerrit_patches_chain) or \
  File "/usr/lib/python2.7/site-packages/rdopkg/actionmods/rpmfactory.py", line 29, in review_url
    review = gerrit_query(review_n) or {}
  File "/usr/lib/python2.7/site-packages/rdopkg/utils/cmd.py", line 125, in __call__
    *params, **kwargs)
  File "/usr/lib/python2.7/site-packages/rdopkg/utils/cmd.py", line 48, in run
    cmd_str = ' '.join(cmd)
TypeError: sequence item 7: expected string or Unicode, int found
Akrog commented 4 years ago

Proposed fix: https://softwarefactory-project.io/r/16719