search

softwarefactory-project / rdopkg

power to the packagers
Apache License 2.0
28 stars 21 forks source link

reqcheck: add comparison of test deps #42

Open apevec opened 8 years ago

apevec commented 8 years ago

Currently reqcheck is comparing only runtime dependencies:

usage: rdopkg reqcheck [-h] inspect requirements.txt vs .spec Requires

As %check is enabled to run unit tests during the build, we need tools to keep up with changing upstream test requirements. One tool would be comparing test-requirements.txt vs .spec BuildRequires and the other one comparing pip freeze from actual venv where unit tests were executed (tox -epy27) vs rpm -qa python-* from rpm buildroot. CLI-wise, both could be additional options for reqcheck but feel free to propose better UX:

usage: rdopkg reqcheck [-h] [ --test ] inspect requirements.txt vs .spec Requires With --test inspect test-requirements.txt vs .spec BuildRequires and also compare Python packages in actual virtualenv vs Python RPMs in buildroot

javierpena commented 8 years ago

About the path-to-venv, maybe rdopkg could try to generate the venv itself using pip install -r on a temporary directory?

apevec commented 8 years ago

@javierpena good idea, rdopkg could simulate both venv and buildroot! That would simplify UX, I've updated proposed CLI in description accordingly.

yac commented 7 years ago

Someone wanted to help with this so I created pseudo-review with general instructions on howto get this done:

https://review.rdoproject.org/r/#/c/5764/