softwarefactory-project / rdopkg

power to the packagers
Apache License 2.0
28 stars 21 forks source link

Add flag to run 'rdopkg patch' even if no new patches introduced #90

Closed bregman-arie closed 7 years ago

bregman-arie commented 7 years ago

Needed for our CI, to run automatically, without asking questions :)

yac commented 7 years ago

Indeed, same as non-interactive new-version suggested by @hguemar: https://review.rdoproject.org/r/#/c/2406/

yac commented 7 years ago

What should happen when distgit is already up to date with patches branch? Usually, that means you already have the latest package built so there is no reason to run rdopkg patch and bump release.

Maybe just end with "No new patches detcted." like update-patches instead of mostly useless question to proceed anyway?

bregman-arie commented 7 years ago

I have no problem with the question "proceed anyway?" as long as I have some flag to answer yes. Like 'rdopkg patch -f/--force' or 'rdopkg patch -y/--yes', but I'm also k with what you proposing :+1:

yac commented 7 years ago

I'd rather change behavior to cover all cases without new flags if possible and this makes sense for non-interactive use while also being consistent with update-patches.

Note that #81 must be also fixed before this is useful.

bregman-arie commented 7 years ago

:+1: