search

softwareinmotion / ibanizator

Ruby gem for calculating iban out of account details.
MIT License
30 stars 21 forks source link

Replace sqlite db with csv file #3

Closed djmaze closed 10 years ago

djmaze commented 10 years ago
djmaze commented 10 years ago

Closes #1.

djmaze commented 10 years ago

Hi Julien,

thanks for your feedback. I just did a SELECT from the sqlite db and saved the resulting text as a CSV. Quick and dirty, I know.

I think opening the file in Excel is not a use-case for this project. The point in still using a CSV file instead of a Hash is to keep it easily updateable. Where did you get the database from? Maybe we should just use the original file (which hopefully is a correctly comma-separated CSV file)?

Otherwise, I agree - using a constant is a better solution.

Happy new year, too!

christoph-feb22 commented 10 years ago

Hi,

the input for the database is from a text file from here: http://www.bundesbank.de/Redaktion/DE/Standardartikel/Kerngeschaeftsfelder/Unbarer_Zahlungsverkehr/bankleitzahlen_download.html

Unfortunately, this file isn't a CSV file and some BLZ are duplicated. In some of the rows the BIC is missing.

Kind regards