search

softwaremill / diffx

Pretty diffs for scala case classes
Apache License 2.0
342 stars 30 forks source link

Add support for weaver-test #446

Closed dabd closed 1 year ago

dabd commented 1 year ago

Add support for https://github.com/disneystreaming/weaver-test.

ghostbuster91 commented 1 year ago

CI works again, please rebase your PR.

ghostbuster91 commented 1 year ago

Seems like we need to update scala3 version to 3.2.2 to have waver compile.

dabd commented 1 year ago

Seems like we need to update scala3 version to 3.2.2 to have waver compile.

Perhaps the scala3 upgrade should be done in another PR since the minor version bump might not be trivial, then I will rebase? Trivial upgrade, just pushed.

ghostbuster91 commented 1 year ago

Released as 0.9.0, thanks again for the contribution!

dabd commented 1 year ago

Released as 0.9.0, thanks again for the contribution!

Thank you so much, I realise now I forgot to bump the versions matrix to 0.9.0 in weaver.md, due to the scala upgrade.

ghostbuster91 commented 1 year ago

Ah indeed, no worries I will fix that. Thanks for pointing it out.

ghostbuster91 commented 1 year ago

If you wonder why the documentation does not reflect your recent changes it is because there were some breaking changes in readthedocs and our documentation build is failing :upside_down_face:

ghostbuster91 commented 1 year ago

@dabd fixed :)