search

softwaremill / elasticmq

In-memory message queue with an Amazon SQS-compatible interface. Runs stand-alone or embedded.
https://softwaremill.com/open-source/
Apache License 2.0
2.55k stars 195 forks source link

"Lastest" tag is not being updated #156

Closed roribio closed 6 years ago

roribio commented 6 years ago

Hi,

Big fan of this project 🥇

I've noticed that new versions are being released but not being marked as latest. Is this because the newer versions are not considered stable yet?

The reason I ask is that I've got some automation that looks at the latest tag and is triggered to update my builds when a new latest is released.

Thanks, Ronald

adamw commented 6 years ago

@roribio Is that on the docker image?

roribio commented 6 years ago

@adamw My apologies for not being clearer before, I'm referring to GitHub releases.

If you go to the releases page, you can see that the tag release-0.13.8 was promoted to "Latest release". After that, new versions have been released but not promoted to "Latest release". Coincidentally, that is also the last tag to follow the release-X.Y.Z naming pattern.

adamw commented 6 years ago

Ah :) TBH, no idea how GH determines the "latest" tag. I've switched to an automated release process which uses a different naming convention for tags, hence the change.

The latest release is definitely 0.14.6

adamw commented 6 years ago

Ah, I suppose that's because earlier I used to do "GitHub releases" based on the tag - now it's just a tag.

roribio commented 6 years ago

I see. Thanks for the clarification 👍

Is it possible to add a "create Github release" step to your automated process? Using GitHub's API to do so is quite straight forward: https://developer.github.com/v3/repos/releases/#create-a-release.

Unfortunately, Github's API doesn't provide an easy way to query the "latest" tag. You need to know the tag's SHA in advance: https://developer.github.com/v3/git/tags/. It does let you query for the latest release though, which is what I'm using: https://developer.github.com/v3/repos/releases/#get-the-latest-release.

I can provide assistance if needed 👍

adamw commented 6 years ago

I don't have the bandwidth to do this myself right now, but I always accept PRs :)

The release steps are defined here: https://github.com/adamw/elasticmq/blob/master/build.sbt#L53, adding the release should probably be somewhere around tagRelease

roribio commented 6 years ago

Thanks for pointing me in the right direction. With that, I've managed to cobble something together and submit a PR: https://github.com/adamw/elasticmq/pull/157.

adamw commented 6 years ago

With some adjustments, seems to work. Thanks!

roribio commented 6 years ago

Awesome! Thank you :)