search

softwaremill / scala-clippy

Good advice for Scala compiler errors
Apache License 2.0
312 stars 20 forks source link

No Clippy advice for implicit ordering. #27

Closed peterkagey closed 7 years ago

peterkagey commented 7 years ago

I'm trying to add advice for: No implicit Ordering defined for java.time.LocalDateTime

And it looks like it's not supported yet.

ShaneDelmore commented 7 years ago

I'll tackle this request.

adamw commented 7 years ago

Fixed in 0.3.3. Thanks @ShaneDelmore for the patch! @peterokagey could you try submitting advice now? :)

peterkagey commented 7 years ago

I pasted the original message reported (No implicit Ordering defined for java.time.LocalDateTime)

When I went to contribute at https://scala-clippy.org/, I saw this somewhat confusing message (which is missing LocalDateTime) : Implicit Ordering typeclass not found error: for type java.time.

Note: the fix works well in my project!

peterkagey commented 7 years ago

Thanks for the fix @ShaneDelmore!

adamw commented 7 years ago

Seems there is a difference in regexpes in JS and JVM :) Should be fixed now (0.3.4)