Load all advices from resources named *.clippy.json

softwaremill / scala-clippy

Good advice for Scala compiler errors

Apache License 2.0

312 stars 20 forks source link

Load all advices from resources named *.clippy.json #53

Closed ShaneDelmore closed 7 years ago

ShaneDelmore commented 7 years ago

For compatibility with the soon to be released sbt-imclipitly https://github.com/ShaneDelmore/imclipitly

kciesielski commented 7 years ago

Honestly I don't know :) It's probably difficult to test automatically but would be good to do at least some manual tests with a snapshot build to verify if it will pull files from libs as intended. Can you check it?

ShaneDelmore commented 7 years ago

Definitely. I may not be able to test it until the weekend but I will definitely test it and follow up. I manually tested with files in various depths of nesting in the target folder but did not check files in a jar yet.

kciesielski commented 7 years ago

Sounds good. The code LGTM, hopefully it will work well with files in jars.