search

softwaremill / sttp

The Scala HTTP client you always wanted!
https://sttp.softwaremill.com
Apache License 2.0
1.45k stars 301 forks source link

Prometheus backend wrapper using too old a version of underlying JVM prometheus client #2246

Closed mihaisoloi closed 1 month ago

mihaisoloi commented 1 month ago

The CollectorRegistry has been renamed and it's now PrometheusRegistry, if you interact with Micrometer you can't use this integration because of the old version sttp prometheus-backend is using.

mihaisoloi commented 1 month ago

I'm referring to this https://github.com/prometheus/client_java/blob/main/prometheus-metrics-model/src/main/java/io/prometheus/metrics/model/registry/PrometheusRegistry.java

mihaisoloi commented 1 month ago

Ok, just realised that this is only the case for sttp3 and it's fixed in sttp4