search

softwaremill / sttp

The Scala HTTP client you always wanted!
https://sttp.softwaremill.com
Apache License 2.0
1.46k stars 309 forks source link

Netty Eviction Warning #752

Closed omar-f closed 3 years ago

omar-f commented 3 years ago

Hello all,

I'm seeing this eviction warning in SBT when adding in async-http-client-backend-future.

[warn] Found version conflict(s) in library dependencies; some are suspected to be binary incompatible:
[warn]  * io.netty:netty-handler:4.1.48.Final is selected over 4.1.43.Final
[warn]      +- org.asynchttpclient:async-http-client:2.12.1       (depends on 4.1.48.Final)
[warn]      +- io.netty:netty-codec-http:4.1.48.Final             (depends on 4.1.48.Final)
[warn]      +- com.typesafe.netty:netty-reactive-streams:2.0.4    (depends on 4.1.43.Final)

I am using version 2.2.9.

I found this older issue which is related, https://github.com/softwaremill/sttp/issues/101.

Here is the dependency graph.

SBT dependency graph
adamw commented 3 years ago

Is this causing any problems?

Also, as you you can see on the graph, the eviction in the async-http-client dependency subtree, so if at all, I think this might be an issue for https://github.com/AsyncHttpClient/async-http-client ?

omar-f commented 3 years ago

Nope, it's not causing any issues, I just figured the dependency could be upgraded. But you are right, I didn't notice it's actually from https://github.com/AsyncHttpClient/async-http-client.