softwaremill / tapir

Rapid development of self-documenting APIs
https://tapir.softwaremill.com
Apache License 2.0
1.37k stars 420 forks source link

Add support for Finagle #280

Open valikon opened 5 years ago

valikon commented 5 years ago

Hi, it would be really nice to have support for Finagle. As you already have support for Finatra which is a REST framework on top of Finagle, I imagine it would not be that hard or time-consuming. Thanks.

zhenwenc commented 5 years ago

Is it possible to support Finch (aka Finchx) as well? The APIs are so similar!

adamw commented 5 years ago

@zhenwenc May be :) Are they all based on finagle-http? Maybe we could have a single interpreter and three APIs, or somehow share the code? Unfortunately I'm not too proficient in the twitter ecosystem :)

zhenwenc commented 5 years ago

Had a quick look earlier, the integration with Finch may not be too easy though, will have a deeper investigation later.

redkhalil commented 2 years ago

Is integration with finagle available?

adamw commented 2 years ago

@redkhalil sorry, only Finatra is available currently. I suspect adding Finagle shouldn't be too hard, though.

redkhalil commented 1 year ago

Finatra is already good for me, that's great news. Keep it up!