'Remove' buttons behave differently

softwaresaved / lowfat

The Software Sustainability Institute's low effort Fellowship Administration Tool (lowFAT). Contact: @gperu

https://softwaresaved.github.io/lowfat/

Other

13 stars 3 forks source link

'Remove' buttons behave differently #763

Open gperu opened 6 months ago

gperu commented 6 months ago

'Remove' buttons behave differently in the funding request, expense and blogopost review page.

Larger issue is: should we removing things at all from the system.

OscarSeip commented 2 months ago

Update: No funding request should be completed deleted from the system.

phillybroadbent commented 1 month ago

Currently, clicking the 'Remove' button in the detail view or clicking the 'x' in the dashboard table will delete the funding request/expense claim/blog post from the system altogether. Setting the status to 'Remove' in the review form will remove the item from the dashboard but it will still be available in the admin area of lowfat. I suggest that the 'Remove' button in detail view and 'x' in table could be deleted, leaving only the option to set the status to 'Remove'.

gperu commented 3 weeks ago

Implementation:

remove the 'remove' button
keep the 'remove' status
'remove' status removes a submission from lowFAT dashboard
submision is kept in lowFAT admin

See screenshots attached,