softwareunderground / 52things

52 Things You Should Know About Geocomputing
101 stars 61 forks source link

Keep on improving your geocomputing projects (chapter 39) reviewer wanted #71

Closed mycarta closed 4 years ago

mycarta commented 4 years ago

I can use another set of eyes on this chapter's draft: https://github.com/softwareunderground/52things/blob/master/chapters/Niccoli_2.md

My eyes are tired of re-reading it

filippo82 commented 4 years ago

Revisiting old projects is an essential part of how I approach scientific computing. It is a practical way to cement new coding practices or take advantage of insights acquired, for example, after completing courses or through independent study. Additionally, changes in the focus of the work encourages me to revisit a project.

In this chapter, I will go over my favorite example. This project is an anomaly for me as it is the one I worked on for the longest time, but never published or shared anything about it. Below is a detailed account of how it evolved:

filippo82 commented 4 years ago

Hi @mycarta,

I made comments to Chapter 39. I "rewrote" it above. I think the best way would just be to copy the Markdown text above and "diff" it with the original one.

Let me know if you need any clarification on my comments.

Cheers! -Filippo

mycarta commented 4 years ago

OK, @filippo82:

I managed to run the comparison. It was a lot of work, thank you!! it reads very well, so I will accept all your suggestions.

Did you have a chance to look at the notebook (this is NOT required I should say, just curious)?

filippo82 commented 4 years ago

I didn't look at the Notebook! Do you mean this one here?

Ciao!

mycarta commented 4 years ago

Si: https://github.com/mycarta/2D_FFT_filter_tutorial/blob/master/52-things_tutorial.ipynb But absolutely not necessary to check code or do anything.