A Geological Model is a Single Hypothesis - of Many Possible Ones (chapter 34) - review

softwareunderground / 52things

52 Things You Should Know About Geocomputing

102 stars 61 forks source link

A Geological Model is a Single Hypothesis - of Many Possible Ones (chapter 34) - review #89

Closed alex-schaaf closed 4 years ago

alex-schaaf commented 4 years ago

Overall very well written and, save for some copyediting, I'd say this is pretty much ready for publication ✔️
I'd recommend putting the chapter in front of the GemPy chapter (33), as it introduces the need for stochastic modeling and talks about open-source goemodeling software.
Could be updated with explicitly mentioning the by now published GemPy paper when talking about open-source geomodeling tools in the second-to-last paragraph.

mycarta commented 4 years ago

Thanks @pytzcarraldo I paged the author also on the SWUNG #52things channel

flohorovicic commented 4 years ago

Thanks @pytzcarraldo and @mycarta - just to what are the next steps? Do you have a list of review comments for me to go through, @pytzcarraldo? Definitely happy to polish up a bit and include some more recent refs, quite a while ago that I wrote the chapter. Should I just go ahead and then recommit?

Thanks in advance - interesting (and promising) method with the reviews over GitHub (did that once for JOSS), but still need to get used to it :-)

alex-schaaf commented 4 years ago

Essentially what I've posted above are the only comments I had when reading it 😄 According to the guidelines the copyediting happens later on anyways.

So for you @flohorovicic I'd only recommend bringing it a bit up to date with current developments and references (gempy, wellmann & caumon 2018) using a pull request.