softwerkab / fortnox-csharp-api-sdk

.NET SDK for Fortnox API.
MIT License
52 stars 64 forks source link

Fix mapping on field OrganizationNumber from api to entity CompanyInformation #146

Closed WilliamGanrot closed 3 years ago

WilliamGanrot commented 3 years ago

Fix mapping on field OrganizationNumber from api to entity Companyinformation. Api and sdk currently have different spelling on OrganizationNumber and can therefore not map the field

richardrandak commented 3 years ago

Thanks for the fix

WilliamGanrot commented 3 years ago

No worries, may I ask how often you publish a new version of the sdk? I could really use the fix, otherwise ill use the api directly.

Från: @.> Skickat: den 1 april 2021 16:54 Till: @.> Kopia: @.>; @.> Ämne: Re: [FortnoxAB/csharp-api-sdk] Fix mapping on field OrganizationNumber from api to entity CompanyInformation (#146)

Thanks for the fix

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/FortnoxAB/csharp-api-sdk/pull/146#issuecomment-811963850, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMKGBV4EDUXR2WIHMXYJWG3TGSCKBANCNFSM42HGH3CQ.

richardrandak commented 3 years ago

Hello William! sorry for late response. I was off due to the holidays. There is no release strategy, so I can do the release with your fix today,

WilliamGanrot commented 3 years ago

No worries, completely understandable. I would really appreciate if you could make a release today

/William Från: @.> Skickat: den 6 april 2021 09:45 Till: @.> Kopia: @.>; @.> Ämne: Re: [FortnoxAB/csharp-api-sdk] Fix mapping on field OrganizationNumber from api to entity CompanyInformation (#146)

Hello William! sorry for late response. I was off due to the holidays. There is no release strategy, so I can do the release with your fix today,

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/FortnoxAB/csharp-api-sdk/pull/146#issuecomment-813905256, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMKGBVY5DGLIFHVT4XULEM3THK3Z7ANCNFSM42HGH3CQ.

richardrandak commented 3 years ago

Done. Check NuGet 4.0.6

WilliamGanrot commented 3 years ago

Thank you so much!

Skickades från E-posthttps://go.microsoft.com/fwlink/?LinkId=550986 för Windows 10

Från: @.> Skickat: den 6 april 2021 10:22 Till: @.> Kopia: @.>; @.> Ämne: Re: [FortnoxAB/csharp-api-sdk] Fix mapping on field OrganizationNumber from api to entity CompanyInformation (#146)

Done. Check NuGet 4.0.6

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/FortnoxAB/csharp-api-sdk/pull/146#issuecomment-813929797, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMKGBVZP2M4TFZP4V6QPOATTHLAC3ANCNFSM42HGH3CQ.