softwerkab / fortnox-csharp-api-sdk

.NET SDK for Fortnox API.
MIT License
52 stars 64 forks source link

Stockpoint #229

Open andersjerenvik opened 2 years ago

andersjerenvik commented 2 years ago

Hi,

Please add

StockPointCode StockPointId

to OrderRow

Thanks;.)

Anders

richardrandak commented 2 years ago

131

133

richardrandak commented 2 years ago

Based on documentation examples, the order has

OrderRow has

Invoice has

Invoice Row has

Is that correct?

andersjerenvik commented 2 years ago

Yes, thats correct

I was wrong so I'm not going to use this fields now. Fortnox doesn't have Stockplace on orderrows so this is not very useful.

Thanks anyway,

Anders

richardrandak commented 2 years ago

I tried to add warehouse related properties, but the problem is with Order.DeliveryState.. if the warehouse module is not enabled, I get an error on when executing order update, even if the property is not modified. The error says the property can not be modified if the warehouse module is not enabled. I can't mark it as readonly (and therfore exclude it in deserialization) since it needs to be updated in some cases.

Går ej att redigera lagerstatus innan lagermodulen har aktiverats.

This would break the functionality.

andersjerenvik commented 2 years ago

Ok, I See.

If you set it to Nullable, is it the same problem?

richardrandak commented 2 years ago

In current use case yes, because the property is populated by the server even if you don't have the warehouse enabled (which is weird). :) ..so you get the order with the delivery state set to "delivery", but it is not accepted during the update.

andersjerenvik commented 2 years ago

Ok, that's probably something to talk to Fortnox about then.