softwerkab / fortnox-csharp-api-sdk

.NET SDK for Fortnox API.
MIT License
53 stars 65 forks source link

EmploymentForm SVT missing in SDK #270

Closed sfiplanday closed 1 year ago

sfiplanday commented 1 year ago

Hi Fortnox Team, our integration uses the SDK to sync employees. However, we are currently getting an error when employees use the employmenttype SVT in Fortnox. On the old API site, it is not listed (https://developer.fortnox.se/documentation/resources/employees/) but on the new site, it is listed as a value (https://apps.fortnox.se/apidocs#operation/list_EmployeesResource). Can this be checked and added to the SDK?

richardrandak commented 1 year ago

Hello! The SDK is not maintained by "Fortnox Team", it's just me now :) I will add the SVT to the enum.

piotrsidor commented 1 year ago

@richardrandak when there will be a new release version of Nuget package with extended enum?

richardrandak commented 1 year ago

@psiplandy Now it is :)

sfiplanday commented 1 year ago

@richardrandak now we get the error that a new key for tax allowance is missing in the SDK: TaxAllowance = SNK not found Do you want a separate request for this? This key is not even listed on the new API from Fortnox

richardrandak commented 1 year ago

I have added the SNK to TaxAllowance.. pleas try now.