update.sh installs dev dependencies during the deployment

softwerkskammer / Agora

Die Software für die Plattform der Softwerkskammer

Other

55 stars 59 forks source link

update.sh installs dev dependencies during the deployment #1470

Open chr1shaefn3r opened 2 years ago

chr1shaefn3r commented 2 years ago

update.sh executes npm ci and therefore installs all dependencies including the dev dependencies, which are not needed (hopefully) in the production deployment. Suggestion would be to use npm ci --production to preven this.

leider commented 2 years ago

What is the benefit-cost ratio? 😀

Seriously: sounds sensible. Maybe you can give it a try locally and report your findings?