search

sofyansitorus / Woongkir

WooCommerce shipping rates calculator for Indonesia domestic and international shipment: AnterAja, 21 Express, Expedito, IDexpress Service Solution, Indotama Domestik Lestari, Indah Logistic, JET Express, Jalur Nugraha Ekakurir (JNE), J&T Express, JTL Express, Lion Parcel, Ninja Xpress, Pahala Express, Pandu Logistics, PCP, POS Indonesia, Royal Express Indonesia, RPX, SAP Express, Sentral Cargo, SiCepat Express, Solusi Ekspres, Star Cargo, TIKI, Wahana Express.
https://wordpress.org/plugins/woongkir/
25 stars 9 forks source link

Fix district with the same name but having different city #23

Closed 0xMMMMMM closed 2 years ago

0xMMMMMM commented 2 years ago

This will fix the district origin when there are same district name but having different city. Before this fix, the origin district returns the first result from array_intersect_assoc whether it was from the right city or not.

sofyansitorus commented 2 years ago

@malikfalasifa Could you please include here in the comment example name of duplicate subdistrict name that could lead this issue.

0xMMMMMM commented 2 years ago

@sofyansitorus Subdistrict name Depok exists in Sleman, Yogyakarta but it will return Depok from Kabupaten Cirebon because the one from Cirebon appeared first. This commit will modify the function so the associated city will be searched too. But of course, please check it.

I've encountered a problem when checking the fee from the courier but getting different result from the official courier website. Because the plugin sending different origin.

sofyansitorus commented 2 years ago

@malikfalasifa Your PR has been published in Woongkir version 1.3.6. Thank you very much for your contribution.