Open chicco785 opened 8 months ago
Kudos, SonarCloud Quality Gate passed!
@chicco785 @guillaume-alliander I've merged #16 . Could you rebase this PR and let me know when it is ready to be reviewed and merged? I would also appreciate an initial review by guillaume as it is indicated in the Reviewers section.
Besides, let me know if you would like to play a leading / maintainer role in this project or cimpy. We have implemented an initial version of cimpy for CGMES 3 (based on your cimgen PR) but could use more hands to boost development speed ;-) See this PR: https://github.com/sogno-platform/cimpy/pull/22
@chicco785 @guillaume-alliander I've merged #16 . Could you rebase this PR and let me know when it is ready to be reviewed and merged? I would also appreciate an initial review by guillaume as it is indicated in the Reviewers section.
@m-mirz i will rebase pr once @guillaume-alliander one is merged. I have already talked with guillame and i will test some additional changes.
Besides, let me know if you would like to play a leading / maintainer role in this project or cimpy. We have implemented an initial version of cimpy for CGMES 3 (based on your cimgen PR) but could use more hands to boost development speed ;-) See this PR: sogno-platform/cimpy#22
Happy to help, with @MarcoPignati (our CTO) we already discussed this. Being a company the work we put may be limited to our needs, but hopefully this is good enough for you :)
For cimpy we need to understand your plans, in my understanding currently it's not based on the "modern python" and we won't make much use of it in that case :(
Maybe a good idea is to have a call also with @guillaume-alliander and share ideas. My timeline currently is quite bad. What about early January?
@chicco785 Ok, for the rebase. I will take care of merging.
Regarding the roadmap and maintainer role, I am going to talk to Jonas at alliander next week and let you know about the next steps. Thanks for your availability even if it is only limited :-)
For cimpy, the one thing that we missed most dearly in python was types. So, we would also support the switch to a modern python version even if that means larger / breaking changes in cimpy.
@guillaume-alliander Could you please review this PR as well?
I have made you maintainer of the project. In case you need more permissions, just let me know.
I saw this PR as ready for review, so I had a look.
A few comments, but the main thing is that right now, no resources files are written when I tried and ran it :)
Also, in PR #21 I split Base.py in a few files, after the comments on pycgmes. There will be rebase needed at some point.
@guillaume-alliander
rebase completed, not sure about the issue you have that nothing is generated... i am passing these args in vscode:
"--outdir", "./build/CGMES_3.0_modernpython", "--schemadir", "./cgmes_schema/CGMES_3.0.0", "--langdir", "modernpython", "--cgmes_version", "cgmes_v3_0_0"
Kudos, SonarCloud Quality Gate passed!
Kudos, SonarCloud Quality Gate passed!
The SonarCloud Quality Gate passed, but some issues were introduced.
11 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication
This pr takes the journey to bring relationships to modernpython generator based on work covered in https://github.com/zaphiro-technologies/cimgen/pull/5. The code is build on top of PR#16, which is required for build reproducibility (using modern library versioning for python).
Tentative plan: